Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 20 Upgrade #45

Closed
3 tasks done
Tracked by #267
BilalQamar95 opened this issue Sep 11, 2024 · 0 comments
Closed
3 tasks done
Tracked by #267

Node 20 Upgrade #45

BilalQamar95 opened this issue Sep 11, 2024 · 0 comments
Assignees
@BilalQamar95

Comments

@BilalQamar95
Copy link
Contributor

BilalQamar95 commented Sep 11, 2024 •
edited
Loading

Description

Part of openedx/public-engineering#232. See openedx/public-engineering#267 for the general description and motivation. Make sure to follow its recommendations for each step of the process.

Tasks
Beta Give feedback
  1. test: Add Node 20 to CI matrix #46
    BilalQamar95
  2. build: Upgrade to Node 20 #47
    BilalQamar95
  3. test: Remove support for Node 18 #48
    BilalQamar95
@BilalQamar95 BilalQamar95 mentioned this issue Sep 13, 2024
Merged
@BilalQamar95 BilalQamar95 self-assigned this Sep 13, 2024
@brian-smith-tcril brian-smith-tcril mentioned this issue Sep 16, 2024
Closed
@BilalQamar95 BilalQamar95 mentioned this issue Sep 19, 2024
Merged
brian-smith-tcril pushed a commit that referenced this issue Sep 19, 2024
@BilalQamar95
build: Upgrade to Node 20 (#47)
a2fe4ec 
### Description

- Regenerated `package-lock.json` with node `v20` and NPM `10`.
- Updated `.nvmrc` to `v20`
- Updated the `lockfile` version check workflow 

Second step in the Node 20 upgrade process, See [the tracking
issue](#45) for
further information.
@BilalQamar95 BilalQamar95 mentioned this issue Sep 20, 2024
Merged
@BilalQamar95 BilalQamar95 moved this to Author Team Review in Arbi-BOM Sep 23, 2024
brian-smith-tcril pushed a commit that referenced this issue Oct 31, 2024
@BilalQamar95
test: Remove support for Node 18 (#48)
34ad344 
### Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using
`.nvmrc` for version to use.

See [the tracking
issue](#45) for
further information.
@github-project-automation github-project-automation bot moved this from Author Team Review to Done in Arbi-BOM Oct 31, 2024
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arbi-BOM Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BilalQamar95 BilalQamar95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BilalQamar95 @brian-smith-tcril