-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Missing external configuration error message #423
fix: Missing external configuration error message #423
Conversation
Thanks for the pull request, @kuipumu! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 97.95% 97.93% -0.02%
==========================================
Files 77 77
Lines 6686 6689 +3
==========================================
+ Hits 6549 6551 +2
- Misses 137 138 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Hi @kuipumu! Would you mind rebasing this pull request? Doing so might help resolve the codecov errors. If that doesn't work, I'll look into it for you. Thanks! |
Hi @kuipumu! Just checking in to see if you plan to pursue this pull request? |
Hi @kuipumu! I'm going to close this pull request for now, but we can reopen in the future if you'd like to pursue. Thanks! |
@kuipumu Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a fix for the LTI external configurations feature issue #420
Type of Change
_get_lti_config_for_block
function onplugin/api.py
module to raise anExternalConfigurationNotFound
error when no external LTI configuration is found.Testing