fix: add utf-8 encoding for user fields #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/update_name_encoding
branch
2 times, most recently
from
651c137
to
ce038d4
Compare
alangsto
force-pushed
the
alangsto/update_name_encoding
branch
from
ce038d4
to
9cc5be0
Compare
zacharis278
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-276
Users with accents in their names are unable to use certain LTI tools because we do not send a utf-8 encoded version of their name to the LTI tool.
This change encodes a user's full name, which is then used in the LTI launch.