Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/otg substation mapping #240

Merged
merged 8 commits into from
May 4, 2021
Merged

Conversation

ulfmueller
Copy link
Member

the subst_id is changed to bus_id in order to simplify the naming conventions throughout the process. The main function is that the mapping of the osmTGmod bus ids and the ids from the substation scripts are realized.

ToDo:
check out the mv grid district scripts and see if the id renaming has impact and requires changes.

@ClaraBuettner
Copy link
Contributor

I tested the scripts and the results look fine, the bus_id in the substation tables fits to the powerflow tables.
The task define_mv_grid_districts fails due to the new column names. I fixed this by changing the subst_id to bus_id (I can also push this).
Since some substations are deleted in osmtgmod_substation the task define_mv_grid_districts has to run afterwards. So another dependency is needed, isn't it?

@ulfmueller
Copy link
Member Author

@ClaraBuettner thx for your review and thx @gplssm for your thumbs up on that. @ClaraBuettner can you please push your changes to this branch. I can add the dependency to the pipeline.

@ulfmueller ulfmueller marked this pull request as ready for review May 4, 2021 09:22
Copy link
Contributor

@ClaraBuettner ClaraBuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the branch again (for Schleswig-Holstein) and the results look fine; there is one hvmv-substation per mv grid district and the ids match.

@IlkaCu IlkaCu merged commit db748e8 into dev May 4, 2021
@IlkaCu IlkaCu deleted the features/otg-substation-mapping branch May 4, 2021 12:29
khelfen pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants