Escape the set commands in Windows batch file #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edalex-ian
reviewed
Apr 27, 2021
Merged
SammyIsConfused
deleted the
bugfix/allow_special_characters_in_windows_path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to address #39.
So in Windows, the Admin Console Package will not work with certain characters in the file path. This is because the set commands in the batch file were not escaped, so when special characters come up they are evaluated during the set command as parts of the command rather than a string value.
This can be avoided by surrounding the content of the set commands with double quotes, to escape the strings and also enabling delayed expansion.