Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

version: bump nightly to 2.4 #10165

Merged
merged 2 commits into from
Jan 14, 2019
Merged

version: bump nightly to 2.4 #10165

merged 2 commits into from
Jan 14, 2019

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jan 10, 2019

No description provided.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations. labels Jan 10, 2019
@5chdn 5chdn added this to the 2.4 milestone Jan 10, 2019
Cargo.lock Outdated Show resolved Hide resolved
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the rand downgrade otherwise it looks good!

@niklasad1 niklasad1 added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 14, 2019
@5chdn
Copy link
Contributor Author

5chdn commented Jan 14, 2019

How? @niklasad1

If I manually edit the Cargo.lock, the pipelines will fail because the Cargo bug will change it back on CI and we do not allow it.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Jan 14, 2019
@5chdn 5chdn merged commit d356c66 into master Jan 14, 2019
@5chdn 5chdn added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 14, 2019
@5chdn 5chdn deleted the a5-nightly-240 branch January 14, 2019 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants