This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove pass-by-reference return data value from executive #9211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorpaas
added
A0-pleasereview 🤓
Closed
sorpaas
added
A3-inprogress ⏳
|
Previously we trace call output via |
sorpaas
added
A0-pleasereview 🤓
pepyakin
reviewed
Jul 24, 2018
| return match call_result { | ||
| MessageCallResult::Success(gas_left, data) => { | ||
| let len = cmp::min(output.len(), data.len()); | ||
| (&mut output[..len]).copy_from_slice(&data[..len]); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
debris
approved these changes
Jul 24, 2018
| @@ -431,7 +438,6 @@ impl<'a, B: 'a + StateBackend> Executive<'a, B> { | |||
| Err(evm_err) | |||
| } else { | |||
| self.state.discard_checkpoint(); | |||
| output.write(0, &builtin_out_buffer); | |||
debris
added
A8-looksgood 🦄
andresilva
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel #6744
Return data is always available from
FinalizationResult, so using pass-by-reference inExecutiveparameters doesn't give us any performance benefits. This reference also creates some trouble for resumableExecutive.This PR changes it so that output is read from
FinalizationResult::return_data. Anunsafeinevmcrate was also able to be removed due to this change.