Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

ethcore: add transition flag for transaction permission contract #9275

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

andresilva
Copy link
Contributor

Replaces #8940.

@andresilva andresilva added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 2, 2018
@andresilva
Copy link
Contributor Author

andresilva commented Aug 2, 2018

cc @Tbaut update docs with this. It's only enabled if the contract address is defined. If the contract address is defined then the transition block defaults to 0 if none is provided.

Copy link
Collaborator

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tbaut
Copy link
Contributor

Tbaut commented Aug 3, 2018

@andresilva as a general reflex (and for any dev when updating such small things), if you can create a PR for the wiki when introducing a new flag, that'd be great. I did it for this one though :)

@ascjones ascjones added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 7, 2018
@ascjones ascjones merged commit 712101b into master Aug 7, 2018
@ascjones ascjones deleted the andre/tx-permission-contract-transition branch August 7, 2018 14:18
ordian added a commit to ordian/parity that referenced this pull request Aug 10, 2018
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  ethcore: add transition flag for transaction permission contract (openethereum#9275)
  Remove all dapp permissions related settings (openethereum#9120)
  Improve return data truncate logic (openethereum#9254)
  Update wasm-tests hash (openethereum#9295)
  Implement KIP4: create2 for wasm (openethereum#9277)
  Fix loop start value (openethereum#9285)
  Avoid using $HOME if not necessary (openethereum#9273)
  Fix path to parity.h (openethereum#9274)
@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants