This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Update patricia trie to 0.2.2 #9525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @cheme signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
cheme
added
A0-pleasereview 🤓
debris
reviewed
Sep 11, 2018
debris
added
A5-grumble 🔥
ordian
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
Note, that this PR also updates ethcore/res/ethereum/tests submodule 👍. I edited PR description to close the issue automatically (see https://help.github.com/articles/closing-issues-using-keywords/).
This was referenced Sep 11, 2018
|
I agree with Marek, that we should revert unrelated changes, since the tests don't pass and it would be easier to backport in that case. |
|
Change to ethtests was a mistake, sorry. |
|
Thanks Ordian for the PR description update. |
ordian
reviewed
Sep 11, 2018
| @@ -1901,7 +1901,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| dependencies = [ | |||
| "num-integer 0.1.39 (registry+https://github.com/rust-lang/crates.io-index)", | |||
| "num-traits 0.2.5 (registry+https://github.com/rust-lang/crates.io-index)", | |||
| "rand 0.4.3 (registry+https://github.com/rust-lang/crates.io-index)", | |||
There was a problem hiding this comment.
I wonder where did this downgrade come from?
There was a problem hiding this comment.
it's unrelated: rust-lang/cargo#5702
debris
approved these changes
Sep 11, 2018
debris
added
A8-looksgood 🦄
andresilva
approved these changes
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update patricia trie to 0.2.2. It also switch to only targeting its minor version in Cargo.toml.
0.2.2 from 0.2.1 adds paritytech/parity-common#38 which closes #9180 .