-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
It looks like @gabreal signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
scripts/gitlab/check-changes.sh
Outdated
if [ "${RUST_FILES_MODIFIED}" = "0" ] | ||
then | ||
echo "__________Skipping Rust tests since no Rust files modified__________"; | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a nicer way to do this? "no files modified" is a valid result and should not result in a failing job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately not. will only become very unbeautiful. so i removed the check stage again. but builds take way to long IMHO before switching to it. Also there are errors in the stage within the CI as well as Rust code that does not seem to compile properly on all platforms.
Stages still need to be debugged, prob one could add allow_failure directives for some platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this should be done only for nightly.
Adnd add changes https://github.com/paritytech/parity-ethereum/blob/master/scripts/gitlab/push.sh#L55
…-fix-windows * 'master' of https://github.com/paritytech/parity: while working on the platform tests make them non-breaking (openethereum#9563) Improve P2P discovery (openethereum#9526) move dockerfile for android build container to scripts repo (openethereum#9560) Simultaneous platform tests WIP (openethereum#9557)
please see how builds could work for testing in parallel.
macos looks pretty slow.