-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CachedCheckResolver for caching Check subproblems #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
+ Coverage 82.34% 82.52% +0.19%
==========================================
Files 64 66 +2
Lines 7760 7969 +209
==========================================
+ Hits 6389 6576 +187
- Misses 1069 1088 +19
- Partials 302 305 +3
☔ View full report in Codecov by Sentry. |
jon-whit
commented
Jul 28, 2023
miparnisari
reviewed
Jul 31, 2023
miparnisari
reviewed
Jul 31, 2023
miparnisari
reviewed
Jul 31, 2023
jon-whit
commented
Aug 1, 2023
adriantam
reviewed
Aug 1, 2023
adriantam
reviewed
Aug 1, 2023
adriantam
force-pushed
the
query-caching
branch
from
August 1, 2023 21:12
02c443a
to
6f72c3e
Compare
miparnisari
requested changes
Aug 1, 2023
adriantam
force-pushed
the
query-caching
branch
from
August 2, 2023 14:57
b7d572c
to
7171524
Compare
jon-whit
commented
Aug 2, 2023
jon-whit
commented
Aug 2, 2023
jon-whit
commented
Aug 2, 2023
jon-whit
commented
Aug 2, 2023
adriantam
force-pushed
the
query-caching
branch
from
August 2, 2023 20:24
c876122
to
aec53ef
Compare
adriantam
added a commit
to openfga/openfga.dev
that referenced
this pull request
Aug 2, 2023
4 tasks
elbuo8
reviewed
Aug 3, 2023
adriantam
force-pushed
the
query-caching
branch
from
August 4, 2023 17:16
f3e2dc9
to
67c6b3b
Compare
jon-whit
commented
Aug 4, 2023
jon-whit
commented
Aug 4, 2023
jon-whit
commented
Aug 15, 2023
jon-whit
commented
Aug 15, 2023
jon-whit
commented
Aug 15, 2023
jon-whit
commented
Aug 15, 2023
jon-whit
commented
Aug 15, 2023
jon-whit
commented
Aug 16, 2023
jon-whit
commented
Aug 16, 2023
jon-whit
commented
Aug 16, 2023
LGTM. Left one comment above about adding a test to |
miparnisari
requested changes
Aug 17, 2023
miparnisari
previously approved these changes
Aug 17, 2023
miparnisari
reviewed
Aug 17, 2023
miparnisari
reviewed
Aug 17, 2023
miparnisari
approved these changes
Aug 17, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces an implementation of the
CheckResolver
interface and wires up dispatch delegation in a way that caches Check subproblems between invocation ofResolveCheck
calls.References
Closes #889
Review Checklist
main