Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verbose option of openfisca test fails #1293

Closed
Tracked by #1309
benjello opened this issue Nov 9, 2024 · 1 comment · Fixed by #1297
Closed
Tracked by #1309

verbose option of openfisca test fails #1293

benjello opened this issue Nov 9, 2024 · 1 comment · Fixed by #1297
Assignees
Labels
kind:fix Bugs are defects and failure demand.

Comments

@benjello
Copy link
Member

benjello commented Nov 9, 2024

Hi there!

I really enjoy OpenFisca, but I recently encountered an issue.

Here is what I did:

I ran with openfisca-core >= 43

openfisca test -c openfisca_france tests/fiches_de_paie/ingenieur_ssii_2013-08.yaml -v

Here is what I expected to happen:

I expected to obtain a verbose test or at least a passing test

Here is what actually happened:

I got

FAILED tests/fiches_de_paie/ingenieur_ssii_2013-08.yaml:: - TypeError: '>' not supported between instances of 'int' and 'NoneType'

This error is not present with core 41.5.3

I also added an error int the test file and a depth option to investigate more

openfisca test -c openfisca_france tests/fiches_de_paie/ingenieur_ssii_2013-08.yaml -v -d 4

The computation log was printed in core 41.5.3 but o output in >=43

cc @bonjourmauko

@sandcha
Copy link
Collaborator

sandcha commented Nov 18, 2024

A first analysis shows that we are missing tests of the trace option. 😬
And to write these tests we need to find the right syntax; our test command is built on top of pytest and our current tests do not show examples including this pytest syntax change: Node Construction changed to Node.from_parent (which is a little bit more complex than it looks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:fix Bugs are defects and failure demand.
Projects
Status: Answer given / Dealt with
Development

Successfully merging a pull request may close this issue.

3 participants