Implement in-place processing for non feature-based algorithms #5514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 02f43f9: arm64-android |
domi4484
approved these changes
Aug 7, 2024
|
|
||
| bool ok; | ||
| QVariantMap results = mAlgorithm->run( parameters, context, &feedback, &ok, { { QStringLiteral( "IN_PLACE" ), true } } ); | ||
| if ( ok ) |
There was a problem hiding this comment.
What in case is not ok? Should we show the error somehow?
There was a problem hiding this comment.
Error handling needs thinking in separate PR for both feature based and this type of alg.
| @@ -33,6 +33,7 @@ | |||
| <file>ProcessingAlgorithmForm.qml</file> | |||
| <file>ProcessingAlgorithmPreview.qml</file> | |||
| <file>processingparameterwidgets/ProcessingParameterWidgetBase.qml</file> | |||
| <file>processingparameterwidgets/boolean.qml</file> | |||
There was a problem hiding this comment.
I would name those files ProcessingParameterWidgetBoolean.qml, ProcessingParameterWidgetEnum.qml, ... to find them easier when searching
There was a problem hiding this comment.
I'm trying to stick to what we do for the feature form editor widgets which also rely on type name without adding a prefix.
|
Now I also tested on my phone, very cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful if models can eventually advertise in-place editing support.
In the meantime, this is still a pretty cool PR: we get the critical buffer algorithm 🥳
vokoscreenNG-2024-08-04_15-56-07.mp4