-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bluetooth] Add support for RadonEye (BLE) device #11958
Conversation
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
if (radon != null) { | ||
logger.debug("Parsed data radon: {}", String.format("[radon=%d Bq/m3]", radon)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line fails silently.
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
8fd6dfd
to
a07b36a
Compare
@wborn this is ready now, I am running this in my "production" and completed all checks. My only issue is if I have given appropriate reference to the people who made the Airthings bluetooth binding - also would they make good reviewers, since this is based mostly on their code. |
Thanks for the PR @petero-dk! We only reference authors by their real name and only for non-trivial contributions. So I think you can safely remove:
I've also requested a review from a few other bluetooth binding contributors. 🙂 |
I have removed the reference, but I would not say their contribution is non-trivial as this contribution is literally a repurpose of the Airthings Binding :-) |
Signed-off-by: Peter Obel <[email protected]>
3f2e76d
to
56fa765
Compare
Any news on the reviews? Anything I can do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @petero-dk for your contribution and your patience!
Code looks good to me, I just have one last question - see below.
bundles/org.openhab.binding.bluetooth.radoneye/src/main/resources/OH-INF/thing/radoneye.xml
Outdated
Show resolved
Hide resolved
…ces/OH-INF/thing/radoneye.xml
I tried to use the binary, is it the current build? The thing shows a com error in the ui and the logs are not verry helpful:
I am able to manually connect to the RD200 device (firmware 2.0.2)
|
Also, I don't know why the CI build compiles all modules? It fails on some other module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope you can fix the DCO, otherwise LGTM
I tried, but apparently I am not smart enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @petero-dk and thanks for the review, @lsiepel!
The DCO is fine, it is part of the first commit and I simply squash the commits when merging.
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]> Signed-off-by: miloit <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Signed-off-by: Peter Obel <[email protected]>
Similar to airthings, provide a specific bluetooth device implementation to handle radon detection via the RadonEye
Only tested with original RadonEye RD200, compiled jar is available here:
org.openhab.binding.bluetooth.radoneye-3.3.0-SNAPSHOT.jar.zip
CI built jar can be downloaded here: https://openhab.jfrog.io/ui/native/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.bluetooth.radoneye