Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mapdb] Make serialization asynchronous #14900

Merged
merged 2 commits into from
May 1, 2023
Merged

[mapdb] Make serialization asynchronous #14900

merged 2 commits into from
May 1, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Apr 28, 2023

Fixes #14899

The serialization was done synchronously. Calls to GSON are time-consuming and should therefore be done asynchronously to allow .store to return fast.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Apr 28, 2023
@J-N-K
Copy link
Member Author

J-N-K commented Apr 28, 2023

@florian-h05 FYI.

@J-N-K
fix tests
a58bc95 
Signed-off-by: Jan N. Klug <[email protected]>
florian-h05
florian-h05 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now, no more performance issues like described in openhab/openhab-core#3578, thanks 👍

Code LGTM!

@J-N-K J-N-K marked this pull request as ready for review April 28, 2023 21:24
clinique
clinique approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

lolodomo
lolodomo approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 990700d into openhab:main May 1, 2023
@lolodomo lolodomo added this to the 4.0 milestone May 1, 2023
@J-N-K J-N-K deleted the mapdb branch May 1, 2023 07:10
@J-N-K J-N-K mentioned this pull request May 1, 2023
Merged
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
@J-N-K @tburri-alstom
[mapdb] Make serialization asynchronous (openhab#14900)
9cb2443 
* [mapdb] Make serialization asynchronous

---------

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
@J-N-K @matchews
[mapdb] Make serialization asynchronous (openhab#14900)
4f8f955 
* [mapdb] Make serialization asynchronous

---------

Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

@lolodomo lolodomo lolodomo approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

[mapdb] Persistence service blocks item notifications
4 participants
@J-N-K @clinique @lolodomo @florian-h05