Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to core changes (FilterCriteria) #14952

Merged
merged 1 commit into from
May 8, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 7, 2023

Related to openhab/openhab-core#2871

I just found that the added null-annotations to FilterCriteria break the build here.

Signed-off-by: Jan N. Klug <[email protected]>
@J-N-K J-N-K added the critical label May 7, 2023
@J-N-K J-N-K requested review from a team, lujop and ssalonen as code owners May 7, 2023 20:15
}

@Test
public void testSimpleUnboundedItemWithoutParams() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this test because the only difference to other tests is that no item name is provided. That is something we do not support.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo added this to the 4.0 milestone May 8, 2023
@lolodomo lolodomo merged commit c3a9a4c into openhab:main May 8, 2023
@lolodomo lolodomo changed the title Adjust to core changes Adjust to core changes (FilterCriteria) May 8, 2023
@J-N-K J-N-K deleted the persistenceregistry branch May 8, 2023 07:47
tb4jc pushed a commit to tb4jc/openhab-addons that referenced this pull request Jun 19, 2023
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Thomas Burri <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Aug 9, 2023
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Matt Myers <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants