Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Support for Plus Dimmer 10v #15950

Merged
merged 5 commits into from
Nov 25, 2023

Conversation

markus7017
Copy link
Contributor

@markus7017 markus7017 commented Nov 23, 2023

Adds a new device

Closing #15949

@markus7017 markus7017 added the enhancement An enhancement or new feature for an existing add-on label Nov 23, 2023
@markus7017 markus7017 self-assigned this Nov 23, 2023
@markus7017 markus7017 linked an issue Nov 23, 2023 that may be closed by this pull request
@markus7017 markus7017 requested a review from jlaur November 23, 2023 22:39
@markus7017
Copy link
Contributor Author

@lolodomo changes applied

Signed-off-by: Markus Michels <[email protected]>
Signed-off-by: Markus Michels <[email protected]>
@markus7017
Copy link
Contributor Author

@lolodomo changes applied

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit a4da986 into openhab:main Nov 25, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Nov 25, 2023
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
* Implements openhab#15949: Plus Dimmer 10v added
* category DimmableLight does not exist; README updated

---------

Signed-off-by: Markus Michels <[email protected]>
@markus7017 markus7017 deleted the shelly_plusdimmer10v branch January 27, 2024 12:53
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* Implements openhab#15949: Plus Dimmer 10v added
* category DimmableLight does not exist; README updated

---------

Signed-off-by: Markus Michels <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[shelly] Support for Plus Dimmer 10V
2 participants