Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[radiothermostat] Add units to README #16411

Merged
merged 3 commits into from
Feb 16, 2024
Merged

[radiothermostat] Add units to README #16411

merged 3 commits into from
Feb 16, 2024

Conversation

mlobstein
Copy link
Contributor

Add units and other minor readme edits.

@mlobstein
Add units and minor edits
8f9fe25 
Signed-off-by: Michael Lobstein <[email protected]>
jlaur
jlaur reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added one minor (optional) formatting comment not directly related to your changes.

Perhaps it would be worth mentioning the unit also in the table of channels? This will help in case of linking to a raw Number item.

Please note that there are also two temperature channels which could benefit from having the unit mentioned (°F).

bundles/org.openhab.binding.radiothermostat/README.md Outdated Show resolved Hide resolved
@mlobstein
update formatting
bb28db7 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
update channel table
cdcd9f9 
Signed-off-by: Michael Lobstein <[email protected]>
@mlobstein
Copy link
Contributor Author

Thanks! I have added one minor (optional) formatting comment not directly related to your changes.

Perhaps it would be worth mentioning the unit also in the table of channels? This will help in case of linking to a raw Number item.

Please note that there are also two temperature channels which could benefit from having the unit mentioned (°F).

I added (°F) to the three temperature channels in the table. If this is not what you were thinking, can you show an example?

@jlaur
Copy link
Contributor

jlaur commented Feb 16, 2024

I added (°F) to the three temperature channels in the table. If this is not what you were thinking, can you show an example?

Perfect!

jlaur
jlaur approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 4cb2df5 into openhab:main Feb 16, 2024
3 checks passed
@jlaur jlaur added this to the 4.2 milestone Feb 16, 2024
@mlobstein mlobstein deleted the radiothermostat_doc branch February 16, 2024 14:58
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@mlobstein @austvik
[radiothermostat] Add units to README (openhab#16411)
860d4ce 
* Add units and minor edits

Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@mlobstein @joni1993
[radiothermostat] Add units to README (openhab#16411)
97ad3b2 
* Add units and minor edits

Signed-off-by: Michael Lobstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mlobstein @jlaur