-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[radiothermostat] Add discovery-methods #16768
Merged
lsiepel
merged 2 commits into
openhab:main
from
mlobstein:radiothermostat-suggestion-finder
May 24, 2024
Merged
[radiothermostat] Add discovery-methods #16768
lsiepel
merged 2 commits into
openhab:main
from
mlobstein:radiothermostat-suggestion-finder
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
added
the
enhancement
An enhancement or new feature for an existing add-on
label
May 16, 2024
jlaur
reviewed
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I have added one small question, otherwise LGTM.
bundles/org.openhab.binding.radiothermostat/src/main/resources/OH-INF/addon/addon.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
mlobstein
force-pushed
the
radiothermostat-suggestion-finder
branch
from
May 18, 2024 04:31
98dee46
to
f56159c
Compare
mlobstein
added
awaiting other PR
Depends on another PR
and removed
awaiting other PR
Depends on another PR
labels
May 18, 2024
The core PR is merged. This can be merged now. |
lsiepel
approved these changes
May 24, 2024
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jun 15, 2024
* Add discovery-methods Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Paul Smedley <[email protected]>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* Add discovery-methods Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Patrik Gfeller <[email protected]>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* Add discovery-methods Signed-off-by: Michael Lobstein <[email protected]>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* Add discovery-methods Signed-off-by: Michael Lobstein <[email protected]>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
* Add discovery-methods Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Ciprian Pascu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add discovery-methods for addon suggestion finder
depends on openhab/openhab-core#4232