[mqtt.homeassistant] Fix duplicate component resolution when unique_id is set #17803
+180
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d is set unique_id is only unique per component type. so we need to a) take that into account, and b) use that when resolving duplicates Signed-off-by: Cody Cutrer <[email protected]>
ccutrer
force-pushed
the
mqtt-homeassistant-dup-unique_id
branch
from
9582102
to
21e4ea3
Compare
jlaur
reviewed
Nov 25, 2024
...c/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/AbstractComponent.java
Outdated
Show resolved
Hide resolved
…rg/openhab/binding/mqtt/homeassistant/internal/component/AbstractComponent.java Co-authored-by: Jacob Laursen <[email protected]> Signed-off-by: Cody Cutrer <[email protected]>
Heh, yup. Those two cases started off as different resolutions, but ended up the same. Fixed. |
jlaur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique_id is only unique per component type. so we need to a) take that into account, and b) use that when resolving duplicates