[paradoxalarm] Discovery service implementation #5826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Polihronov <[email protected]>
Travis tests were successfulHey @theater, |
theater
changed the title
lolodomo
requested changes
Jul 16, 2019
...c/main/java/org/openhab/binding/paradoxalarm/internal/discovery/ParadoxDiscoveryService.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/paradoxalarm/internal/handlers/ParadoxAlarmHandlerFactory.java
Outdated
Show resolved
Hide resolved
* Changed final map in handler factory to non-final * Removed runtime exception in discovery service implementation logging it at DEBUG level plus trace Signed-off-by: Konstantin Polihronov <[email protected]>
lolodomo
approved these changes
Jul 16, 2019
cweitkamp
requested changes
Jul 21, 2019
...main/java/org/openhab/binding/paradoxalarm/internal/handlers/ParadoxAlarmHandlerFactory.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/paradoxalarm/internal/discovery/ParadoxDiscoveryService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/paradoxalarm/internal/discovery/ParadoxDiscoveryService.java
Outdated
Show resolved
Hide resolved
...main/java/org/openhab/binding/paradoxalarm/internal/handlers/ParadoxAlarmHandlerFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Konstantin Polihronov <[email protected]>
Signed-off-by: Konstantin Polihronov <[email protected]>
cweitkamp
added
the
enhancement
sprehn
pushed a commit
to sprehn/openhab-addons
that referenced
this pull request
Aug 21, 2019
* Discovery service implementation Signed-off-by: Konstantin Polihronov <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Discovery service implementation Signed-off-by: Konstantin Polihronov <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
wborn
changed the title
wborn
removed
the
enhancement
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Dec 8, 2019
* Discovery service implementation Signed-off-by: Konstantin Polihronov <[email protected]>
tmrobert8
pushed a commit
to tmrobert8/openhab-addons
that referenced
this pull request
Jan 21, 2020
* Discovery service implementation Signed-off-by: Konstantin Polihronov <[email protected]> Signed-off-by: Tim Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paradox alarm - Discovery service implementation
[paradoxalarm] Implementation of discovery service for entities. Bridge must be configured. When it establishes communication with security system, the discovery service can gather all entities (partitions, zones and panel info)
Signed-off-by: Konstantin Polihronov [email protected]