[somfytahoma] bug fixes for the V2 API #6699

octa22 · 2019-12-28T20:40:30Z

This PR contains bug fixes for the API v2 migration mentined in the forum
https://community.openhab.org/t/tahoma-binding-compatible-with-oh2/27004/388

Fixes #6533

changes:

bug fixes (SmokeSensor, Light, "too many requests")
improved the device discovery
improved MY position setting
added the cloud reconciliation feature (regular sync against the Tahoma Cloud)
added support for the Water & Humidity sensor devices
added support fot the Myfox camera & alarm devices
added support for the Roller shutter UNO devices

TravisBuddy · 2019-12-29T12:04:37Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

wborn · 2019-12-29T12:13:08Z

I've changed the base branch of this PR to 2.5.x @octa22, see #6702.

TravisBuddy · 2019-12-31T14:29:07Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-01T22:48:23Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-03T20:10:11Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-04T09:20:07Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-04T13:48:53Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-04T13:49:49Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-04T13:58:46Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-04T23:56:29Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-05T23:21:22Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-07T20:43:03Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-07T21:03:10Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-07T22:18:40Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

TravisBuddy · 2020-01-15T17:36:23Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Ondrej Pecta <[email protected]>

TravisBuddy · 2020-01-15T17:56:51Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

martinvw

Do all people require this now or can people still be using/needing the old API? It looks good to me.

...ain/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaMyfoxCameraHandler.java

octa22 · 2020-01-15T22:38:39Z

Do all people require this now or can people still be using/needing the old API? It looks good to me.

The Somfy v2 API is already part of the OH 2.5.0, this PR contains some bug fixes and adds support for some new things. Hope it will be part of the next release (affected users may get the latest version in the forum)

Signed-off-by: Ondrej Pecta <[email protected]>

TravisBuddy · 2020-01-18T12:19:49Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K

Thanks. Some nice improvements. I have left some comments in the code.

...java/org/openhab/binding/somfytahoma/internal/discovery/SomfyTahomaItemDiscoveryService.java

.../main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBaseThingHandler.java

...src/main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaBridgeHandler.java

...rc/main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaGatewayHandler.java

...ain/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaMyfoxCameraHandler.java

...rc/main/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaDeviceDefinition.java

...in/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaDeviceDefinitionState.java

TravisBuddy · 2020-01-18T22:15:26Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K

Otherwise LGTM.

...fytahoma/src/main/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaAction.java

...ytahoma/src/main/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaCommand.java

Signed-off-by: Ondrej Pecta <[email protected]>

TravisBuddy · 2020-01-19T09:38:47Z

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K · 2020-01-19T09:46:45Z

Thanks.

bugfixes (SmokeSensor, Light, "too many requests") improved the device discovery improved MY position setting added the cloud reconciliation feature (regular sync against the Tahoma Cloud) added support for the Water & Humidity sensor devices added support for the Myfox camera & alarm devices added support for the Roller shutter UNO devices Fixes: openhab#6533 Signed-off-by: Ondrej Pecta <[email protected]>

bugfixes (SmokeSensor, Light, "too many requests") improved the device discovery improved MY position setting added the cloud reconciliation feature (regular sync against the Tahoma Cloud) added support for the Water & Humidity sensor devices added support for the Myfox camera & alarm devices added support for the Roller shutter UNO devices Fixes: openhab#6533 Signed-off-by: Ondrej Pecta <[email protected]> Signed-off-by: Tim Roberts <[email protected]>

bugfixes (SmokeSensor, Light, "too many requests") improved the device discovery improved MY position setting added the cloud reconciliation feature (regular sync against the Tahoma Cloud) added support for the Water & Humidity sensor devices added support for the Myfox camera & alarm devices added support for the Roller shutter UNO devices Fixes: openhab#6533 Signed-off-by: Ondrej Pecta <[email protected]> Signed-off-by: leluna <[email protected]>

bugfixes (SmokeSensor, Light, "too many requests") improved the device discovery improved MY position setting added the cloud reconciliation feature (regular sync against the Tahoma Cloud) added support for the Water & Humidity sensor devices added support for the Myfox camera & alarm devices added support for the Roller shutter UNO devices Fixes: openhab#6533 Signed-off-by: Ondrej Pecta <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>

bugfixes (SmokeSensor, Light, "too many requests") improved the device discovery improved MY position setting added the cloud reconciliation feature (regular sync against the Tahoma Cloud) added support for the Water & Humidity sensor devices added support for the Myfox camera & alarm devices added support for the Roller shutter UNO devices Fixes: openhab#6533 Signed-off-by: Ondrej Pecta <[email protected]>

octa22 added the bug An unexpected problem or unintended behavior of an add-on label Dec 28, 2019

This comment has been minimized.

Sign in to view

octa22 changed the title ~~[somfytahoma] bug fixes for the V2 API~~ [WIP][somfytahoma] bug fixes for the V2 API Dec 29, 2019

octa22 force-pushed the somfytahoma-binding-bugfix branch from a56c8f2 to c0bffbb Compare December 29, 2019 01:48

This comment has been minimized.

Sign in to view

wborn changed the base branch from master to 2.5.x December 29, 2019 11:40

wborn force-pushed the somfytahoma-binding-bugfix branch from 0ba3288 to 5868698 Compare December 29, 2019 11:59

wborn mentioned this pull request Dec 29, 2019

Handling of Pull Requests #6702

Closed

wborn added the work in progress A PR that is not yet ready to be merged label Dec 30, 2019

octa22 force-pushed the somfytahoma-binding-bugfix branch from 5868698 to 155e211 Compare December 31, 2019 14:25

octa22 force-pushed the somfytahoma-binding-bugfix branch 2 times, most recently from 9eb3831 to 344e744 Compare January 1, 2020 22:44

octa22 force-pushed the somfytahoma-binding-bugfix branch from b1de050 to c4b32ad Compare January 4, 2020 09:16

octa22 force-pushed the somfytahoma-binding-bugfix branch from c4b32ad to d90a49c Compare January 4, 2020 13:44

octa22 force-pushed the somfytahoma-binding-bugfix branch from e6eb442 to 3c66ae0 Compare January 7, 2020 22:14

octa22 force-pushed the somfytahoma-binding-bugfix branch from 3c66ae0 to 3f1e310 Compare January 7, 2020 22:46

octa22 force-pushed the somfytahoma-binding-bugfix branch from b4882ec to 5ceeb79 Compare January 15, 2020 17:32

[somfytahoma] improved refreshing of items

5ebc8fe

Signed-off-by: Ondrej Pecta <[email protected]>

octa22 force-pushed the somfytahoma-binding-bugfix branch from 5ceeb79 to 5ebc8fe Compare January 15, 2020 17:52

martinvw approved these changes Jan 15, 2020

View reviewed changes

...ain/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaMyfoxCameraHandler.java Outdated Show resolved Hide resolved

martinvw requested a review from a team January 15, 2020 20:27

[somfytahoma] added support for the Somfy thermostat

e30940b

Signed-off-by: Ondrej Pecta <[email protected]>

J-N-K requested changes Jan 18, 2020

View reviewed changes

J-N-K requested changes Jan 19, 2020

View reviewed changes

...fytahoma/src/main/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaAction.java Outdated Show resolved Hide resolved

...ytahoma/src/main/java/org/openhab/binding/somfytahoma/internal/model/SomfyTahomaCommand.java Outdated Show resolved Hide resolved

[somfytahoma] addressed comments from the code review

61db17f

Signed-off-by: Ondrej Pecta <[email protected]>

octa22 force-pushed the somfytahoma-binding-bugfix branch from 959e41d to 61db17f Compare January 19, 2020 09:34

J-N-K approved these changes Jan 19, 2020

View reviewed changes

martinvw merged commit 76c07bf into openhab:2.5.x Jan 20, 2020

martinvw removed the cre Coordinated Review Effort label Jan 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[somfytahoma] bug fixes for the V2 API #6699

[somfytahoma] bug fixes for the V2 API #6699

octa22 commented Dec 28, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Dec 29, 2019

wborn commented Dec 29, 2019

TravisBuddy commented Dec 31, 2019

TravisBuddy commented Jan 1, 2020

TravisBuddy commented Jan 3, 2020

TravisBuddy commented Jan 4, 2020

TravisBuddy commented Jan 4, 2020

TravisBuddy commented Jan 4, 2020

TravisBuddy commented Jan 4, 2020

TravisBuddy commented Jan 4, 2020

TravisBuddy commented Jan 5, 2020

TravisBuddy commented Jan 7, 2020

TravisBuddy commented Jan 7, 2020

TravisBuddy commented Jan 7, 2020

TravisBuddy commented Jan 15, 2020

TravisBuddy commented Jan 15, 2020

martinvw left a comment

octa22 commented Jan 15, 2020

TravisBuddy commented Jan 18, 2020

J-N-K left a comment

TravisBuddy commented Jan 18, 2020

J-N-K left a comment

TravisBuddy commented Jan 19, 2020

J-N-K commented Jan 19, 2020

[somfytahoma] bug fixes for the V2 API #6699

[somfytahoma] bug fixes for the V2 API #6699

Conversation

octa22 commented Dec 28, 2019 • edited Loading

This comment has been minimized.

This comment has been minimized.

TravisBuddy commented Dec 29, 2019

Travis tests were successful

wborn commented Dec 29, 2019

TravisBuddy commented Dec 31, 2019

Travis tests were successful

TravisBuddy commented Jan 1, 2020

Travis tests were successful

TravisBuddy commented Jan 3, 2020

Travis tests were successful

TravisBuddy commented Jan 4, 2020

Travis tests were successful

TravisBuddy commented Jan 4, 2020

Travis tests were successful

TravisBuddy commented Jan 4, 2020

Travis tests were successful

TravisBuddy commented Jan 4, 2020

Travis tests were successful

TravisBuddy commented Jan 4, 2020

Travis tests were successful

TravisBuddy commented Jan 5, 2020

Travis tests were successful

TravisBuddy commented Jan 7, 2020

Travis tests were successful

TravisBuddy commented Jan 7, 2020

Travis tests were successful

TravisBuddy commented Jan 7, 2020

Travis tests were successful

TravisBuddy commented Jan 15, 2020

Travis tests were successful

TravisBuddy commented Jan 15, 2020

Travis tests were successful

martinvw left a comment

Choose a reason for hiding this comment

octa22 commented Jan 15, 2020

TravisBuddy commented Jan 18, 2020

Travis tests were successful

J-N-K left a comment

Choose a reason for hiding this comment

TravisBuddy commented Jan 18, 2020

Travis tests were successful

J-N-K left a comment

Choose a reason for hiding this comment

TravisBuddy commented Jan 19, 2020

Travis tests were successful

J-N-K commented Jan 19, 2020

octa22 commented Dec 28, 2019 •

edited

Loading