Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switched to SAT 0.9.0 #6850

Merged
merged 2 commits into from
Jan 17, 2020
Merged

switched to SAT 0.9.0 #6850

merged 2 commits into from
Jan 17, 2020

Conversation

kaikreuzer
Copy link
Member

Signed-off-by: Kai Kreuzer [email protected]

Signed-off-by: Kai Kreuzer <[email protected]>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the extension to the <build> section or there won't be any HTML summary reports. E.g. similar to this commit.

We probably also want to add a formatter using the openhab_wst_feature_file.prefs added in openhab/static-code-analysis#368 for feature files to the existing formats.

@wborn
Copy link
Member

wborn commented Jan 17, 2020

I see there's already #6681 for adding the format.

Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer
Copy link
Member Author

I've added the extension, thanks.

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks! Let's see if the builds are still successful.

@bjoernbrings bjoernbrings merged commit 8610267 into openhab:2.5.x Jan 17, 2020
@kaikreuzer kaikreuzer deleted the sat090 branch January 17, 2020 21:32
wborn pushed a commit to wborn/openhab-addons that referenced this pull request Jan 17, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @kaikreuzer,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @kaikreuzer,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

wborn pushed a commit that referenced this pull request Jan 17, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Jan 20, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this pull request Jan 21, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Tim Roberts <[email protected]>
leluna pushed a commit to leluna/openhab2-addons that referenced this pull request Mar 21, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: leluna <[email protected]>
Hans-Reiner pushed a commit to Hans-Reiner/openhab2-addons that referenced this pull request Apr 11, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
ramack pushed a commit to ramack/openhab-addons that referenced this pull request May 31, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
* switched to SAT 0.9.0

Signed-off-by: Kai Kreuzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants