Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed mysql persistence service #7306

Merged
merged 2 commits into from
Apr 5, 2020
Merged

removed mysql persistence service #7306

merged 2 commits into from
Apr 5, 2020

Conversation

kaikreuzer
Copy link
Member

... as it is obsolete due to the existence of the JDBC MySQL service, see #5275 (comment).

Signed-off-by: Kai Kreuzer [email protected]

@TravisBuddy
Copy link

Travis tests have failed

Hey @kaikreuzer,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal from BOM is mssing

Signed-off-by: Kai Kreuzer <[email protected]>
@kaikreuzer
Copy link
Member Author

Good catch, thanks. We just have too many places where an add-on leaves traces...
Fixed now.

@TravisBuddy
Copy link

Travis tests have failed

Hey @kaikreuzer,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@J-N-K
Copy link
Member

J-N-K commented Apr 5, 2020

True. For removal it may be more complicated but maybe we can add a check for the addition of addons?

@J-N-K J-N-K merged commit 52980da into openhab:master Apr 5, 2020
@kaikreuzer kaikreuzer deleted the mysql branch April 5, 2020 16:43
wborn added a commit to wborn/openhab-addons that referenced this pull request Apr 11, 2020
The add-on got removed in openhab#7306, though this .project file was not removed.

Signed-off-by: Wouter Born <[email protected]>
cpmeister pushed a commit that referenced this pull request Apr 11, 2020
The add-on got removed in #7306, though this .project file was not removed.

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn added this to the 3.0 milestone Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants