Use FeatureInstaller for suggestion finder installation #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
|
LGTM, I would like to hear what @wborn thinks about it. |
|
Let's give it a try. |
J-N-K
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3983
This PR changes the installation/deinstallation of suggestion finders, not directly calling the FeatureService, but through FeatureInstaller. This should reduce the amount of bundle refreshes happening, but will not completely avoid it (the root cause is not with the finders, but the refersh on install/deinstall of any bundle).
At a minimum, it moves the installation/deinstallation into the same code as installing/deinstalling addons, so improvements in that code will also benefit the installation/deinstallation of the addon finders.
@J-N-K @lolodomo let me know if this change is worth doing, or the benefit is too limited.