Persistence restore lastState and lastStateChange on startup #4463
Conversation
Signed-off-by: Mark Herwege <[email protected]>
Signed-off-by: Mark Herwege <[email protected]>
| historicItem.getState()); | ||
| } | ||
| GenericItem genericItem = (GenericItem) item; | ||
| if (!UnDefType.NULL.equals(item.getState())) { |
There was a problem hiding this comment.
Why is this not done before querying the persistence service?
It seems that we could've avoided running the query unnecessarily if the state was already initialised.
There was a problem hiding this comment.
I guess, as the query runs in a separate thread, the item state may have changed in between starting the query and returning the result.
@J-N-K introduced this. I didn't find more explanation for it, but this was my interpretation. So I think it should remain there.
There was a problem hiding this comment.
I guess, as the query runs in a separate thread, the item state may have changed in between starting the query and returning the result.
That makes sense, but I think it would also make sense to check it beforehand as well.
But perhaps if that were the case, such change could be added later, and separately from this PR.
This PR requires #4351
It extends restoreOnStartup to also restore the
lastState,lastStateUpdateandlastStateChangeGenericItem fields. This allows having these fields available and set immediately after a startup without needing a state change.@jimtng FYI