-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inbox: Add Copy .things Definition
(to clipboard) button
#3021
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jimmy Tanagra <[email protected]>
#2719 Bundle Size — 10.98MiB (~+0.01%).d039e1f(current) vs bf2f2ee main#2718(baseline) Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #2719 |
Baseline #2718 |
|
---|---|---|
Initial JS | 1.9MiB |
1.9MiB |
Initial CSS | 577.21KiB |
577.21KiB |
Cache Invalidation | 18.04% |
17.39% |
Chunks | 227 |
227 |
Assets | 250 |
250 |
Modules | 2951 |
2951 |
Duplicate Modules | 154 |
154 |
Duplicate Code | 1.8% |
1.8% |
Packages | 98 |
98 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #2719 |
Baseline #2718 |
|
---|---|---|
JS | 9.19MiB (~+0.01% ) |
9.19MiB |
CSS | 867.06KiB |
867.06KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.38KiB |
1.38KiB |
Other | 871B |
871B |
Bundle analysis report Branch jimtng:inbox-copy-definition Project dashboard
Generated by RelativeCI Documentation Report issue
How is generated this syntax? Kind of hardcoded I assume. |
Yes it's very simple and hard coded. I've just seen your core PR, so we'll wait until that gets through. |
Is this a PR for webui? If so, should I close my PR? |
No, only new REST API. So core framework. |
Purpose
This allows us to quickly create the Thing inside a .things file from the discovered Inbox items.
Note: I chose the text color
blue
here, because once #3020 is merged, the other blue button will go away, so visually, it will remain quite distinct from the other buttons for instant identification.Background
This was discussed / requested by @seime here:
https://community.openhab.org/t/adjust-width-of-f7-dialog-include-clipboard-icon/154117
Screenshots
Once clicked, it shows a Toast message:
Output
The copied text looks like this: