Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location Picker: Set default to system location, otherwise set to worldwide zoom level #3047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Location Picker: Set default to system location, otherwise set to worldwide zoom level #3047

wants to merge 1 commit into from

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Jan 30, 2025

Resolve #2999

@jimtng jimtng marked this pull request as draft January 30, 2025 04:41
@jimtng
Copy link
Contributor Author

jimtng commented Jan 30, 2025

Waiting for feedback

@relativeci RelativeCI
Copy link

relativeci bot commented Jan 30, 2025

#2758 Bundle Size — 10.98MiB (~+0.01%).

6ba1d65(current) vs 95844d2 main#2743(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2758		      Baseline
#2743
No change  Initial JS 1.9MiB 1.9MiB
No change  Initial CSS 577.21KiB 577.21KiB
Change  Cache Invalidation 17.39% 17.51%
No change  Chunks 227 227
No change  Assets 250 250
No change  Modules 2952 2952
No change  Duplicate Modules 154 154
No change  Duplicate Code 1.8% 1.8%
No change  Packages 98 98
No change  Duplicate Packages 2 2
Bundle size by type  Change 7 changes Regression 7 regressions
                 Current
#2758		      Baseline
#2743
Regression  JS 9.19MiB (+100%) undefined
Regression  CSS 867.33KiB (+100%) undefined
Regression  Fonts 526.1KiB (+100%) undefined
Regression  Media 295.6KiB (+100%) undefined
Regression  IMG 140.74KiB (+100%) undefined
Regression  HTML 1.38KiB (+100%) undefined
Regression  Other 871B (+100%) undefined

Bundle analysis report Branch jimtng:map-default-location-zoom Project dashboard

Generated by RelativeCI Documentation Report issue

@jimtng jimtng marked this pull request as ready for review January 31, 2025 00:23
@jimtng
Copy link
Contributor Author

jimtng commented Jan 31, 2025

this is now ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghys ghys Awaiting requested review from ghys ghys is a code owner

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MainUI] Map picker should center on location set in regional settings
1 participant
@jimtng