Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Update Z-wave products.xml for additional Everspring HSM02 id values #1557

Merged
merged 2 commits into from
Oct 16, 2014

Conversation

mattgwatson
Copy link
Contributor

My Everspring HSM02 gives a product ID of 0002. There already exists an entry for this devices in the Z-Wave database but for product ID 0001. Mine appears to be identical to the existing everspring/hsm02.xml, so I've just modified products.xml to use the existing hsm02.xml for product ID 0002.

Perhaps a different ID value for the north american frequency?

@buildhive
Copy link

openhab » openhab #1401 SUCCESS
This pull request looks good
(what's this?)

@@ -253,6 +253,16 @@
</Product>
<Product>
<Reference>
<Type>0002</Type>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add the whole new section - to add a new reference, you can just add the lines -:

<Reference>
<Type></Type>
<Id></Id>
</Reference>

below the existing reference section.

Can you update this to that format please?

@cdjackson cdjackson self-assigned this Oct 15, 2014
@mattgwatson
Copy link
Contributor Author

Yep no problem. Should have realized the xml could be parsed that way. Anyways, I've fixed it and pushed the commit.

@buildhive
Copy link

openhab » openhab #1403 SUCCESS
This pull request looks good
(what's this?)

cdjackson added a commit that referenced this pull request Oct 16, 2014
Update Z-wave products.xml for additional Everspring HSM02 id values
@cdjackson cdjackson merged commit 0d1b6f1 into openhab:master Oct 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants