-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve NPM experience #33 #34
Conversation
Can we please publish this if it's OK to merge? Cheers, |
Good point about tests. They were added by mistake because I used a tool to generate the file. I'll remove them and update the PR. Regarding Node, let's include it the way it is for now. You already have good naming for them. Ideally you'd want a neater import for these like So what we have will work for now for Node. |
Check it now and let me know what you think. I deleted the tests references from the barrel. |
Okay, this looks better. Can you also sign the CLA ? https://github.com/openid/AppAuth-JS/blob/master/CONTRIBUTING.md |
Done for both 2 CLA documents. |
Also received an email from Mike Leszcz saying the signature was processed. |
Fixes #33