-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make nonce optional for OAuth servers that don't support it. #282
Comments
The right approach here (to avoid sending nonce to a non-compliant provider) is to use the designated initializer of OIDAuthorizationRequest and pass AppAuth-iOS/Source/OIDAuthorizationRequest.h Lines 183 to 216 in b4ca39a
|
You're completely right, I'll update my PR on the |
AppAuth-iOS worked correctly with AWS Cognito up until its 0.93 release that fixed #4. The issue lies in the inabilty of Cognito to handle the nonce parameter (mentioned in their forums here).
There is a comment on the
OIDAuthorizationRequest.h
file that mentions something about it being nullable:The thing is, my team is not using AppAuth-iOS directly but rather trough a wrapper since our project is built with React Native, and we need a way to expose this functionality to that wrapper.
I've opened a PR that implements our fix to this, its also linked to another PR on the wrapper repo.
The text was updated successfully, but these errors were encountered: