Correct OIDServiceDiscovery's NSCoding implementation #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danblakemore
reviewed
Sep 9, 2022
danblakemore
reviewed
Sep 9, 2022
danblakemore
reviewed
Sep 9, 2022
danblakemore
approved these changes
Sep 9, 2022
eigentone11
added a commit
to eigentone11/AppAuth-iOS
that referenced
this pull request
Sep 13, 2022
* commit '74239430b5219ba502d34349288cd27db010eca2': Update issue templates (openid#723) Prep for 1.6.0 release (openid#722) Correct OIDServiceDiscovery's NSCoding implementation (openid#721) Update OIDServiceConfiguration.m (openid#656) Add prefersEphemeralSession parameter for external user-agents (openid#645) Update ObjC style guide link. # Conflicts: # UnitTests/OIDServiceDiscoveryTests.m
eigentone11
added a commit
to eigentone11/AppAuth-iOS
that referenced
this pull request
Sep 13, 2022
* master: update deployment target Update issue templates (openid#723) Prep for 1.6.0 release (openid#722) Correct OIDServiceDiscovery's NSCoding implementation (openid#721) Update OIDServiceConfiguration.m (openid#656) Add prefersEphemeralSession parameter for external user-agents (openid#645) Update ObjC style guide link.
tonyphn
pushed a commit
to brighthr/AppAuth-iOS
that referenced
this pull request
Feb 2, 2023
* Improve NSCoding implementation. * Test new and old encodings. * Ensure that we're handling the old encoding without errors. * No need to supply an empty failure string. * Provide forward compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide our own implementation of
NSCodingforOIDServiceDiscoveryrather than delegating toNSDictionaryand maintain support for decoding the old encoding for backward compatibility. Ensure that OIDServiceConfiguration can successfully decode the old encoding whenrequiresSecureCodingis enabled. Test both new and old encodings withrequiresSecureCodingenabled.