Fix nullability annotation for -[OIDExternalUserAgentIOS init]

[tiwoc]

This PR fixes this build warning:

Source/AppAuth/iOS/OIDExternalUserAgentIOS.h:37:1: warning build: conflicting nullability specifier on return types, 'nullable' conflicts with existing specifier 'nonnull'

Unfortunately, this warning is misleading. -[NSObject init] doesn't have any nullability annotation, which is equivalent to null_unspecified, but -[OIDExternalUserAgentIOS init] has the conflicting nullable annotation.

The straightforward solution would be to remove the annotation here to get in sync with the base class, but this would be incorrect: In line 34, NS_ASSUME_NONNULL_BEGIN is used, which would make the annotation default to nonnull instead of null_unspecified, which is why null_unspecified has to be used explicitly.

To verify the fix, run the iOS tests in this repository with and without this PR. With this PR applied, the warning will no longer show up.

Fixes #442

[tiwoc]

@petea, is there anything I can improve here to make it more likely to get this merged? I'm working on bringing down the number of build warnings in the project I'm working on to zero so that new warnings in our own code stick out.

[petea]

@tiwoc I'm waiting for the next major release to address the handful of nullability annotation issues that we have since the fixes cause breaking API surface changes on the Swift side.

In the meantime, have you signed the contributor agreements?

[tiwoc]

Thanks for letting me know.

In the meantime, have you signed the contributor agreements?

👍

[LaurentiuUngur]

Any updates on this ? Thank you !

[orj]

I too would like this addressed. init being nullable is not valid Objective-C or Swift.

[imfractured]

hey can we get this merged? I'm looking to use this framework for an enterprise app but this issue has been going on in the background for the last few years. please get this resolved? its literally 3 lines of code and we don't need anyone to take credit for it, we just need it fixed please!!!

[cornr]

Hi @petea, we would also like to see this warning to vanish from our project. Is there a timeframe for the next major release?

[krissbennett]

This looks to be approved but not merged? It would be great to get this in a new release so can get rid of this warning.
Is there an ETA for this getting into a release?

[ChrisPearce]

Hi @petea. Is it intended that this pull request will be merged and included in a release?

[Vyazovoy]

Hi! Please release these trivial changes or at least let us know why can't it be merged 😊

[mdmathias]

This lgtm. We don't have immediate plans for a release, but will have to make one soon (sometime in mid Q4, perhaps) to add a privacy manfiest. This change will be included in that release.

[CarlSarkisS]

@HadesPTIT Could you please explain that revert? The warning is especially annoying for pods relying on AppAuth, as by default we want to block the release if there are warnings (and this is a good rule).
There seems to be a consensus on the validity of b376a87, could you please detail your push-back?

[tiwoc]

@CarlSarkisS The revert happened on the HadesPTIT/AppAuth-iOS fork, not the upstream openid/AppAuth-iOS repo. It won't make its way into this repo.

[CarlSarkisS]

@tiwoc, oh, ok, I had missed that :)
Do you know when it will be released into a 1.6.3 or 1.7.0?

[tiwoc]

I wish I knew.

[ashok]

Bumping it up as still affected by this issue on v1.6.2. Waiting for new release.

OIDExternalUserAgentIOS.h:37:1: conflicting nullability specifier on return types, 'nullable' conflicts with existing specifier 'nonnull'

- (nullable instancetype)init API_AVAILABLE(ios(11))

[macdrevx]

+1 looking forward to a new release with this fix. We were in the process of switching to SPM to install this dependency, but it looks like we may be sticking with CocoaPods since we can't find a way to prevent the warning from failing our CI builds which treat swift warnings as errors.

[mdmathias]

This will come out in an upcoming release with AppAuth's privacy manifest. I do not have a specific date, but it will be before Apple's spring 2024 deadline for privacy manifests.