Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing method to OIDAuthorizationResponse #825

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

mdmathias
Copy link
Collaborator

AppAuth release 1.7.0 inadvertently removed a method from the public interface of OIDAuthorizationResponse. This PR adds the method back.

This fix and subsequent release should fix google/GoogleSignIn-iOS#376.

@mdmathias mdmathias requested a review from yalkhder March 9, 2024 00:05
@mdmathias mdmathias merged commit 4b6948f into master Mar 9, 2024
10 checks passed
@mdmathias mdmathias deleted the mdmathias/fix-missing-method branch March 9, 2024 00:08
@sengoontoh
Copy link

Will there be a release soon?

@mdmathias
Copy link
Collaborator Author

@sengoontoh Yes, I am working on that release now. Apologies!

@mdmathias
Copy link
Collaborator Author

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 13, 2024
Revert #144861

#144860 was resolved by openid/AppAuth-iOS#825

I'm just going to mark this as unflaky instead of waiting for the bot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants