Replace references to "URL" by "URI" when resource identifiers are not required to be resource locators #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t required to be resource locators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OAuth 2.0/OpenID Connect, most - if not all - of the endpoints/callbacks are defined by one or more URIs. While in most cases those URIs will be URLs, the specifications don't require it and URNs can be freely used when necessary.
OpenIddict itself heavily relies on
System.Urito represent these concepts but usesURL(oraddress) instead ofURIin most of the error descriptions and exceptions. This PR fixes that by using the genericURIname instead of the more specificURL/addressterms.Note: this PR changes a few parameter names in the stores. Maintainers of community-driven stores will be encouraged to use the updated names for consistency (typically
addresses->uris) 😃Related: #1613.