Consolidate declarations of MAX_ARRAY_SIZE in one place

[stsypanov]

In JDK there are multiple declarations of maximum array size (Integer.MAX_VALUE - 8) with exactly the same code and documentaion.
In some places, e.g. in AbstractStringBuilder they have no use in code, only in JavaDoc, in other ones they could be substituted with one single declaration. We already have one in jdk.internal.util.ArraysSupport and it can be propagated into java.util.Arrays and used from there (also making it available for JDK users).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1506/head:pull/1506
$ git checkout pull/1506

[bridgekeeper]

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@stsypanov The following labels will be automatically applied to this pull request:

• core-libs
• hotspot-jfr
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[RogerRiggs]

The value of the implementation limit for array sizes is not a specified fixed value and should not be public, it may need to change one day.

[stsypanov]

@RogerRiggs thanks for pointing this out, I've made the field private

[stuart-marks]

I'd suggest looking at #1617 . That PR not only renames this constant to be more descriptive; it also clarifies its semantics. After it's integrated, I think each of the places that has some constant MAX_ARRAY_SIZE or similar should be revisited and maybe changed to use either the constant, or the newLength method, or not changed at all. For example, the usage in InputStream is somewhat different. I don't see any reason that readNBytes should avoid allocating more than MAX_ARRAY_SIZE (or SOFT_MAX_ARRAY_LENGTH) if it had actually read that many bytes. On the other hand, a close look should be given to ArrayDeque, which can probably use newLength directly, since it has a very similar array growth policy as ArrayList.

[bridgekeeper]

@stsypanov This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@stsypanov This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it!