-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8255466: C2 crashes at ciObject::get_oop() const+0x0 #536
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
The GHA report several failures.
|
/approval request Backport JDK-8255466 to fix the corner case in C2. The change has been verified on linux x64 and linux aarch64 with jtreg tier1/2/3. |
@sendaoYan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.
Thanks very much for your patience and careful review. I have created a backport PR of JDK-8250825. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Wait the prefixed PR merged. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Wait the prefixed #552 merged. |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/open |
@sendaoYan This pull request is already open |
Hi all,
This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning
hotspot/src/share/vm/opto/type.cpp:2556:71: error: ‘this’ pointer is null
with gcc13.Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add
bootclasspath
.New test fails without the patch, passes with it.
Additional testing:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536
$ git checkout pull/536
Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/536/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 536
View PR using the GUI difftool:
$ git pr show -t 536
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/536.diff
Using Webrev
Link to Webrev Comment