Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled #591

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Oct 3, 2024

Backport to fix failure on Client VM (win32, arm), seen on adoptium infra:

10:24:53  STDOUT:
10:24:53  CompilerOracle: exclude Test8009761.m2
10:24:53  WB error: invalid compilation level 4
10:24:53  STDERR:
10:24:53  java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled
10:24:53  	at Test8009761.main(Test8009761.java:263)
10:24:53  	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
10:24:53  	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
10:24:53  	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
10:24:53  	at java.lang.reflect.Method.invoke(Method.java:498)
10:24:53  	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
10:24:53  	at java.lang.Thread.run(Thread.java:750)

Interestingly test passes on win32 in GHA. I checked jtr, it tests correct jdk, but seems Server VM is built even on win32 (I thought Client VM was default on win32, but probably not):

JDK under test: C:\\Users\\runneradmin\\jdk-windows-x86\\jdk-1.8.0-internal+0_windows-x86_bin\\j2sdk-image
openjdk version "1.8.0_442-internal"
OpenJDK Runtime Environment (build 1.8.0_442-internal-zzambers-25ceefc7a16f31558ec7e92b7504f328a78d8091-b00)
OpenJDK Server VM (build 25.442-b00, mixed mode)

Backport applied cleanly, only file location is different.

Testing:
GHA: OK (test passes, failures unrelated)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8048003 needs maintainer approval

Issue

  • JDK-8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/591/head:pull/591
$ git checkout pull/591

Update a local copy of the PR:
$ git checkout pull/591
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 591

View PR using the GUI difftool:
$ git pr show -t 591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/591.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@zzambers This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled

Compile m3 with C1 if C2 is not available.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 42c6c17: 8341057: Add 2 SSL.com TLS roots
  • 5b8dfbb: 8338402: GHA: some of bundles may not get removed
  • 02b8101: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 6acc668: 8209023: fix 2 compiler tests to avoid JDK-8208690
  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b4d4c8a3922f6563013d4e997e149bd0198222d2 8048003: test/compiler/8009761/Test8009761.java failed with: java.lang.RuntimeException: static java.lang.Object Test8009761.m3(boolean,boolean) not compiled Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2024
@zzambers
Copy link
Contributor Author

zzambers commented Oct 3, 2024

/approval request Fixes Test8009761.java on Client VM, only affects test, clean, passes GHA

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@zzambers
8048003: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 3, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 22, 2024
@zzambers
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

Going to push as commit 432d962.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 42c6c17: 8341057: Add 2 SSL.com TLS roots
  • 5b8dfbb: 8338402: GHA: some of bundles may not get removed
  • 02b8101: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 6acc668: 8209023: fix 2 compiler tests to avoid JDK-8208690
  • 61a4127: 8251188: Update LDAP tests not to use wildcard addresses
  • b4264bc: 8340815: Add SECURITY.md file

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 22, 2024
@openjdk openjdk bot closed this Oct 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@zzambers Pushed as commit 432d962.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant