-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303408 : [AIX] Broken jdk8u build after JDK-8266391 #33
Conversation
👋 Welcome back deepa181! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@deepa181 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Tagged the JBS issue. |
Thank you so much @phohensee for review. |
Okay. Thanks for tagging the JBS issue. |
/integrate |
I want more approvals for this fix before it gets Merge. Thanks . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks for the fix!
The fix is fine. |
/sponsor |
Going to push as commit 4a83729. |
Thanks @jerboaa for review the code. |
The AIX build fails after JDK-8266391 was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error.
Reported Issue : JDK-8303408
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/33/head:pull/33
$ git checkout pull/33
Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/jdk8u pull/33/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 33
View PR using the GUI difftool:
$ git pr show -t 33
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/33.diff