Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303408 : [AIX] Broken jdk8u build after JDK-8266391 #33

Closed
wants to merge 1 commit into from

Conversation

deepa181
Copy link
Contributor

@deepa181 deepa181 commented Mar 2, 2023

The AIX build fails after JDK-8266391 was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error.

Reported Issue : JDK-8303408


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303408: [AIX] Broken jdk8u build after JDK-8266391

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.org/jdk8u pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/33.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2023

👋 Welcome back deepa181! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 2, 2023
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2023

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@deepa181 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303408: [AIX] Broken jdk8u build after JDK-8266391

Reviewed-by: phh, sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2023
@phohensee
Copy link
Member

Tagged the JBS issue.

@deepa181
Copy link
Contributor Author

deepa181 commented Mar 2, 2023

Lgtm.

Thank you so much @phohensee for review.

@deepa181
Copy link
Contributor Author

deepa181 commented Mar 2, 2023

Tagged the JBS issue.

Okay. Thanks for tagging the JBS issue.

@deepa181
Copy link
Contributor Author

deepa181 commented Mar 2, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 2, 2023
@openjdk
Copy link

openjdk bot commented Mar 2, 2023

@deepa181
Your change (at version e8f5742) is now ready to be sponsored by a Committer.

@deepa181
Copy link
Contributor Author

deepa181 commented Mar 3, 2023

I want more approvals for this fix before it gets Merge. Thanks .

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks for the fix!

@jerboaa
Copy link
Contributor

jerboaa commented Mar 3, 2023

The fix is fine. Metrics is a linux only (cgroups) feature. So returning null is the right thing to do on AIX.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 3, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 3, 2023

Going to push as commit 4a83729.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2023
@openjdk openjdk bot closed this Mar 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 3, 2023
@openjdk
Copy link

openjdk bot commented Mar 3, 2023

@jerboaa @deepa181 Pushed as commit 4a83729.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@deepa181
Copy link
Contributor Author

deepa181 commented Mar 3, 2023

The fix is fine. Metrics is a linux only (cgroups) feature. So returning null is the right thing to do on AIX.

Thanks @jerboaa for review the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants