8271557: Undecorated interactive stage style #594

mstr2 · 2021-07-29T19:50:55Z

This PR introduces StageStyle.UNDECORATED_INTERACTIVE. This style is similiar to StageStyle.UNDECORATED, but adds platform-specific interactions to the window.

For all platforms, this includes move and resize behaviors.
On Windows, it also includes Aero behaviors (snap to screen edges, dock at top to maximize, etc.).

Additionally, on Windows this style adds window animations and a drop shadow (both of which StageStyle.UNDECORATED lacks).

This new style can be used to create custom window decorations without losing window interactions.

Applications that use this stage style need to provide an implementation of WindowRegionClassifier to let the JavaFX windowing subsystem know which parts of the window should afford window interactions:

stage.initStyle(StageStyle.UNDECORATED_INTERACTIVE);

stage.initRegionClassifier(new WindowRegionClassifier() {
    @Override
    public WindowRegion classify(double x, double y, Node nodeAtPosition) {

        // Regions can be identified by the node under the current cursor position...
        if (nodeAtPosition == titleBar) {
            return WindowRegion.TITLE;
        }
        
        // ...or by window coordinates
        if (x < 10) {
            return WindowRegion.LEFT;
        }
        
        if (x > primaryStage.getWidth() - 10) {
            return WindowRegion.RIGHT;
        }

        return WindowRegion.CLIENT;

    }
});

If a window region is not returned from the classifier, no interaction will be available for this region.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Warning

⚠️ Patch contains a binary file (apps/samples/3DViewer/src/test/resources/com/javafx/importers/dae/test-data-maya/duke.png)

Issue

JDK-8271557: Undecorated interactive stage style (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/594/head:pull/594
$ git checkout pull/594

Update a local copy of the PR:
$ git checkout pull/594
$ git pull https://git.openjdk.org/jfx.git pull/594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 594

View PR using the GUI difftool:
$ git pr show -t 594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/594.diff

bridgekeeper · 2021-07-29T19:51:10Z

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

sproket · 2021-07-30T00:16:39Z

This is a great idea!

chengenzhao · 2021-08-14T13:44:58Z

great
please make it happen

SDIDSA · 2021-10-05T19:00:17Z

Please make this happen

Col-E · 2021-12-13T23:49:58Z

This would be great for creating customized themes with different window decorations if that were to be supported some time down the line with this feature.

Is there anything blocking this from moving forward in the review process?

mstr2 · 2021-12-16T17:13:29Z

This would be great for creating customized themes with different window decorations if that were to be supported some time down the line with this feature.

Is there anything blocking this from moving forward in the review process?

This PR is not yet ready for review, as I'm still working on some issues with resize flicker on Windows.

Haven-King · 2022-11-16T22:11:59Z

Any updates here?

TX256 · 2023-01-12T14:11:05Z

I think this is a very important PR.

Undecorated windows have become pretty much the standard nowadays for desktop apps, and the current state of affairs on Windows gives an unprofessional experience - as the minimize, maximize & restore animations are not displayed at all. Not to speak of Aero snapping.

Is there a possibility that this could be done for JavaFX 21?

leewyatt · 2023-01-13T02:57:25Z

Very useful PR, looking forward to it.

futurism-xm · 2023-01-13T03:07:26Z

Very much looking forward to

3563198204qq · 2023-01-13T03:07:48Z

非常期待

yijunjiechen · 2023-01-13T03:08:32Z

Hi @yijunjiechen, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user yijunjiechen for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

zero-zero-one-one · 2023-01-13T03:09:17Z

Very useful PR, looking forward to it.

LIUSHUAI2018 · 2023-01-13T03:12:36Z

Hi @LIUSHUAI2018, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user LIUSHUAI2018 for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Mr-ShiHuaYu · 2023-01-13T03:13:20Z

wow，A very splendid pr, especially looking forward to incorporating it into the official version

Anivie · 2023-01-13T03:14:00Z

I am very supportive of this pr, it is hard to imagine that this feature has not been proposed until now, it is very important to build a modern application.

Xiaobaishushu25 · 2023-01-13T03:14:51Z

nice，this PR Make it easy to customize the window

leewyatt · 2023-01-13T04:15:02Z

@Bridgekeeper Sorry. I discussed this issue in a javafx community, and many people found this feature very useful, so they replied to this discussion; there may be more people replying at a time; I have caused trouble to you, sorry.

leck995 · 2023-01-13T07:34:53Z

It‘s a userful PR,every time I need to do it myself. I hope the official can accept it.

dlemmermann · 2023-01-13T12:09:54Z

Would so love to see this happening.

palexdev · 2023-01-15T15:20:25Z

Can we have this by the next version?

tsayao · 2023-01-27T17:38:08Z

modules/javafx.graphics/src/main/java/com/sun/glass/ui/MoveResizeHelper.java

+    private void handleMoveWindow(int xAbs, int yAbs) {
+        window.setPosition(mouseDownWindowX + xAbs - mouseDownX, mouseDownWindowY + yAbs - mouseDownY);
+    }


On Linux this will be constrained by the window manager, so it's not possible to move the window outside of the desktop bounds, including panels.

This can be done by implementing a beginMoveDrag on glass that will call (on linux):
gdk_window_begin_move_drag

tsayao · 2023-01-27T17:41:52Z

To allow a custom decoration control, the part of the TITLE window region would have to be transparent to allow it to be more customizable, like this:

Notice the rounded borders.

dlemmermann · 2023-06-21T13:26:30Z

Please keep active.

leewyatt · 2023-06-22T03:20:29Z

Please keep active ^_^

leck995 · 2023-07-07T07:48:51Z

Please keep active.

Anivie · 2023-07-08T01:59:33Z

Please keep active.

FlorianKirmaier · 2023-07-20T13:24:04Z

push

bridgekeeper · 2023-09-14T18:58:02Z

@mstr2 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

xdsswar · 2023-10-23T18:11:52Z

I had to do a lot of jni to archive this https://github.com/xdsswar/fx-jni-demo

It works fine, tested on windows 10 and 11. There is some small fix I got to do, but its usable. For now its only for Windows.

palexdev · 2023-10-23T18:18:06Z

I had to do a lot of jni to archive this https://github.com/xdsswar/fx-jni-demo

It works fine, tested on windows 10 and 11. There is some small fix I got to do, but its usable. For now its only for Windows.

Great job, qnd you even used it on a modular project, amazing
Is there the src code for the fx-jni library?

xdsswar · 2023-10-23T18:25:02Z

I had to do a lot of jni to archive this https://github.com/xdsswar/fx-jni-demo
It works fine, tested on windows 10 and 11. There is some small fix I got to do, but its usable. For now its only for Windows.

Great job, qnd you even used it on a modular project, amazing Is there the src code for the fx-jni library?

Yes, I have it , need to upload , but I will share later , Im in the hospital right now with my mom. Also you are the MaterialFx guy right? Amazing job there.

palexdev · 2023-10-23T20:09:32Z

I had to do a lot of jni to archive this https://github.com/xdsswar/fx-jni-demo
It works fine, tested on windows 10 and 11. There is some small fix I got to do, but its usable. For now its only for Windows.

Great job, qnd you even used it on a modular project, amazing Is there the src code for the fx-jni library?

Yes, I have it , need to upload , but I will share later , Im in the hospital right now with my mom. Also you are the MaterialFx guy right? Amazing job there.

Yes, I am, thank you very much! Looking forward to it, I'm very curious on what you came up with

xdsswar · 2023-10-23T21:01:55Z

I had to do a lot of jni to archive this https://github.com/xdsswar/fx-jni-demo
It works fine, tested on windows 10 and 11. There is some small fix I got to do, but its usable. For now its only for Windows.

Great job, qnd you even used it on a modular project, amazing Is there the src code for the fx-jni library?

Yes, I have it , need to upload , but I will share later , Im in the hospital right now with my mom. Also you are the MaterialFx guy right? Amazing job there.

Yes, I am, thank you very much! Looking forward to it, I'm very curious on what you came up with

Here we go https://github.com/xdsswar/shared-fx-jni-src

bridgekeeper · 2023-12-19T03:27:09Z

@mstr2 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

leewyatt · 2023-12-19T07:03:46Z

Very useful PR, looking forward to it.~~

burningtnt · 2023-12-22T09:18:27Z

Please keep active. This feature is so wonderful!.

SDIDSA · 2023-12-24T08:43:02Z

need this so much, maybe implementing custom windows doesn't have to be so painful anymore

bridgekeeper · 2024-02-18T12:27:07Z

@mstr2 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

dlemmermann · 2024-02-18T12:45:29Z

Still want it.

YansideyuoOo · 2024-02-27T04:15:24Z

非常需要这个，也许实现自定义窗口不必再那么痛苦了

openjdk · 2024-03-13T20:01:24Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

bridgekeeper · 2024-05-09T01:25:31Z

@mstr2 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

BelgianDev · 2024-05-13T05:37:07Z

Hi @Raft08, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Raft08" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

len-ny · 2024-07-04T01:46:20Z

Hi @len-ny, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user len-ny" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

len-ny · 2024-07-04T01:47:02Z

Hi @len-ny, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user len-ny" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

I agree to the OpenJDK Terms of Use for all comments I make in a project in the OpenJDK GitHub organization.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

bridgekeeper · 2024-08-29T02:01:38Z

@mstr2 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sproket · 2024-08-30T12:23:39Z

Please keep this!

leck995 · 2024-09-25T01:24:19Z

We need it!

mstr2 added 3 commits July 29, 2021 20:52

added undecorated-interactive window style

acfbff8

changes

054ca0e

docs

34d943e

remove Window.UndecoratedMoveResizeHelper

2a75424

mstr2 changed the title ~~Undecorated-interactive stage style~~ 8271557: Undecorated interactive stage style Jul 30, 2021

doc changes and copyright header

b4e8d1d

overheadhunter mentioned this pull request Sep 14, 2021

Persist last known window position and improve resizing cryptomator/cryptomator#1761

Merged

tsayao reviewed Jan 27, 2023

View reviewed changes

Glavo mentioned this pull request Feb 18, 2024

[Bug] 在 Hyprland 窗口管理器下運行時出現多餘的邊框且選項提示無法正常顯示 HMCL-dev/HMCL#2778

Closed

mkpaz mentioned this pull request Aug 8, 2024

Add AppStage to support window without an operating system border mkpaz/atlantafx#99

Closed

mstr2 closed this Oct 19, 2024

mstr2 mentioned this pull request Oct 20, 2024

8313424: JavaFX controls in the title bar #1605

Open

4 tasks

8271557: Undecorated interactive stage style #594

8271557: Undecorated interactive stage style #594

Conversation

mstr2 commented Jul 29, 2021 • edited by openjdk bot Loading

Progress

Warning

Issue

Reviewing

bridgekeeper bot commented Jul 29, 2021

sproket commented Jul 30, 2021 • edited by bridgekeeper bot Loading

chengenzhao commented Aug 14, 2021 • edited by bridgekeeper bot Loading

SDIDSA commented Oct 5, 2021 • edited by bridgekeeper bot Loading

Col-E commented Dec 13, 2021 • edited Loading

mstr2 commented Dec 16, 2021

Haven-King commented Nov 16, 2022 • edited by bridgekeeper bot Loading

TX256 commented Jan 12, 2023 • edited by bridgekeeper bot Loading

leewyatt commented Jan 13, 2023 • edited by bridgekeeper bot Loading

futurism-xm commented Jan 13, 2023 • edited by bridgekeeper bot Loading

3563198204qq commented Jan 13, 2023 • edited by bridgekeeper bot Loading

yijunjiechen commented Jan 13, 2023 • edited by bridgekeeper bot Loading

zero-zero-one-one commented Jan 13, 2023 • edited by bridgekeeper bot Loading

LIUSHUAI2018 commented Jan 13, 2023 • edited by bridgekeeper bot Loading

Mr-ShiHuaYu commented Jan 13, 2023 • edited by bridgekeeper bot Loading

Anivie commented Jan 13, 2023 • edited by bridgekeeper bot Loading

Xiaobaishushu25 commented Jan 13, 2023 • edited by bridgekeeper bot Loading

leewyatt commented Jan 13, 2023

leck995 commented Jan 13, 2023 • edited by bridgekeeper bot Loading

dlemmermann commented Jan 13, 2023 • edited by bridgekeeper bot Loading

palexdev commented Jan 15, 2023

tsayao Jan 27, 2023

Choose a reason for hiding this comment

tsayao commented Jan 27, 2023

dlemmermann commented Jun 21, 2023

leewyatt commented Jun 22, 2023

leck995 commented Jul 7, 2023

Anivie commented Jul 8, 2023

FlorianKirmaier commented Jul 20, 2023

bridgekeeper bot commented Sep 14, 2023

xdsswar commented Oct 23, 2023

palexdev commented Oct 23, 2023

xdsswar commented Oct 23, 2023

palexdev commented Oct 23, 2023

xdsswar commented Oct 23, 2023

bridgekeeper bot commented Dec 19, 2023

leewyatt commented Dec 19, 2023

burningtnt commented Dec 22, 2023

SDIDSA commented Dec 24, 2023

bridgekeeper bot commented Feb 18, 2024

dlemmermann commented Feb 18, 2024

YansideyuoOo commented Feb 27, 2024 • edited by bridgekeeper bot Loading

openjdk bot commented Mar 13, 2024

bridgekeeper bot commented May 9, 2024

BelgianDev commented May 13, 2024 • edited by bridgekeeper bot Loading

len-ny commented Jul 4, 2024 • edited by bridgekeeper bot Loading

len-ny commented Jul 4, 2024 • edited by bridgekeeper bot Loading

bridgekeeper bot commented Aug 29, 2024

sproket commented Aug 30, 2024

leck995 commented Sep 25, 2024

mstr2 commented Jul 29, 2021 •

edited by openjdk bot

Loading

sproket commented Jul 30, 2021 •

edited by bridgekeeper bot

Loading

chengenzhao commented Aug 14, 2021 •

edited by bridgekeeper bot

Loading

SDIDSA commented Oct 5, 2021 •

edited by bridgekeeper bot

Loading

Col-E commented Dec 13, 2021 •

edited

Loading

Haven-King commented Nov 16, 2022 •

edited by bridgekeeper bot

Loading

TX256 commented Jan 12, 2023 •

edited by bridgekeeper bot

Loading

leewyatt commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

futurism-xm commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

3563198204qq commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

yijunjiechen commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

zero-zero-one-one commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

LIUSHUAI2018 commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

Mr-ShiHuaYu commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

Anivie commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

Xiaobaishushu25 commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

leck995 commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

dlemmermann commented Jan 13, 2023 •

edited by bridgekeeper bot

Loading

YansideyuoOo commented Feb 27, 2024 •

edited by bridgekeeper bot

Loading

BelgianDev commented May 13, 2024 •

edited by bridgekeeper bot

Loading

len-ny commented Jul 4, 2024 •

edited by bridgekeeper bot

Loading

len-ny commented Jul 4, 2024 •

edited by bridgekeeper bot

Loading