Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6684: Adding CONTRIBUTING.md file #46

Closed
wants to merge 2 commits into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Feb 5, 2020

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6684: Add CONTRIBUTING.md file to the JMC project

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 5, 2020

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Feb 5, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2020

Webrevs

Copy link
Collaborator

@Gunde Gunde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the PR section we should maybe put the PR template? I.e. nnnn:Title?

@openjdk
Copy link

openjdk bot commented Feb 11, 2020

@thegreystone This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6684: Adding CONTRIBUTING.md file

Reviewed-by: hdafgard
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 490f619970f7cfff56d12289639816c0f3106939.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2020
@thegreystone
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 11, 2020
@openjdk
Copy link

openjdk bot commented Feb 11, 2020

@thegreystone The following commits have been pushed to master since your change was applied:

  • 490f619: 6677: Search to highlight cells in the flame view
  • ef7f807: 6688: Adding project file for the 2019-12 platform
  • 7485fad: 6686: Adding FAQ to wiki/readme
  • c85d31b: 6685: Parse more fields directly to primitive values

Your commit was automatically rebased without conflicts.

Pushed as commit eb59321.

@openjdk openjdk bot removed the rfr label Feb 11, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: eb59321
Author: Marcus Hirt <hirt at openjdk.org>
Date: 2020-02-11 17:11:54 +0000
URL: https://git.openjdk.java.net/jmc/commit/eb593214

6684: Adding CONTRIBUTING.md file

Reviewed-by: hdafgard

+ CONTRIBUTING.md

@thegreystone thegreystone deleted the contributing branch November 19, 2020 10:41
RealCLanger added a commit to RealCLanger/jmc that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants