Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current fido release 1.4.1 does not find pronom v95 #192

Closed
shsdev opened this issue Jul 21, 2020 · 1 comment
Closed

Current fido release 1.4.1 does not find pronom v95 #192

shsdev opened this issue Jul 21, 2020 · 1 comment
Assignees
@carlwilson
Labels
bug A product defect that needs fixing

Comments

@shsdev
Copy link

shsdev commented Jul 21, 2020

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/fido-1.4.1/fido/conf/formats-v95.xml'

However, conf directory contains formats-v96.xml
carlwilson added a commit that referenced this issue Jul 21, 2020
@carlwilson
FIX: Signature file defaults
a82e85d 
- these were still set to PRONOM 95;
- the process to updated this should be automated; and
- the API development shouldn't assume that Fido enters through main.

Fixes: #192
@carlwilson carlwilson self-assigned this Jul 21, 2020
@carlwilson carlwilson added the bug A product defect that needs fixing label Jul 21, 2020
@carlwilson
Copy link
Member

This is because a non main call is relying on these defaults weren't updated when the last signature update happened. This won't affect anyone using the application as the default values are updated in main here but calling from Python code, e.g. https://github.com/E-ARK-Software/eatb/blob/master/eatb/format/formatidentification.py fails as it relies on a broken default.

@carlwilson carlwilson mentioned this issue Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlwilson carlwilson

Labels
bug A product defect that needs fixing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlwilson @shsdev