FIX: Signature preparation niggles and bugs #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactored `./fido/update_signatures.py` to add clarity; - generated FIDO sig file now validates against `fido/config/fido-formats.xsd` + fixed inconsistency between FIDO sig schema and 'fido/prepare.py''s use of 'apple_uid' and `apple_uti`; - PRONOM HTTP methods in dedicated `./fido/pronom/http.py` module (this needs to get more methods or merging with the SOAP module); - added basic (hacky) catch for 404s when downloading test resources; - safer use of empty list default for `fido/prepare.py FormatInfo:__init__`.
carlwilson
added
bug
|
@sevein this is still a draft until I merge my previous PR but shows where I'm headed and the next set of changes. |
- allow zero signature elements; and - ommitted for previous check in.
- Python 2 compatibility re-established; - Pydoc and line spacing for CI tests on Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./fido/update_signatures.pyto add clarity;fido/config/fido-formats.xsdapple_uti;./fido/pronom/http.pymodule (this needs to get more methods or merging with the SOAP module);fido/prepare.py FormatInfo:__init__.