Add Unicode support in Windows and Python 2.7 #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use win-unicode-console to install various fixes needed in Python 2 on Windows: display of Unicode characters in Windows console, use of unicode in sys.argv, etc... See https://pypi.org/project/win_unicode_console/ for more details.
sevein
force-pushed
the
dev/issue-100-unicode-windows
branch
from
6a83a69 to
e06592f
Compare
mistydemeo
approved these changes
Apr 13, 2021
|
@mistydemeo, thanks for looking at this. That marker is also new to me! This seems to be the full list: https://www.python.org/dev/peps/pep-0508/#environment-markers. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables Unicode support when running Python 2.7 from the Windows console. It relies on the win-unicode-console package which monkeypatches the standard library when
platform.system() == 'Windows' and six.PY2. It can be reverted once fido abandons Python 2.7 (EOL reached) since 3.6+ is perfectly capable.Fixes #100.