Remove reload & sys.setdefaultencoding #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are discouraged usage and deprecated/removed in Python3.
|
No sign of encoding issues, I assume? Maybe this is working around a problem that hasn't been an issue for awhile. |
|
I think this was a hack workaround for printing unicode strings in Python2, where it sometimes assumed the encoding was ASCII instead of UTF8. The correct workaround appears to have been setting PYTHONIOENCODING=UTF8, but I can't reproduce the probable error in Python2 at all. |
|
If it's not reproducible I think we can judge this problem lost to the mists of time. 👍 Probably worth testing with various |
mistydemeo
approved these changes
Oct 13, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are discouraged usage and deprecated/removed in Python3. See http://stackoverflow.com/questions/3828723/why-should-we-not-use-sys-setdefaultencodingutf-8-in-a-py-script
Versions of pyflakes newer than 1.0.0 give an error for
reload()since it's removed in Python3, so this should fix travis errors.