bugfix: unnecessary to do error check #2371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data since it will always succeed
zhuizhuhaomeng
previously approved these changes
Nov 6, 2024
|
There are build error: https://app.travis-ci.com/github/openresty/lua-nginx-module/jobs/627512678#L4413 |
willmafh
changed the title
@zhuizhuhaomeng build error fixed, ping for a second review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx_http_lua_socket_push_input_data will always succeed and therefore change its signature to void return type, it's unnecessary to do error check of it.
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.