Skip to content

Commit

Permalink
Adds TODO for Noop Implementation
Browse files Browse the repository at this point in the history
Signed-off-by: Darshit Chanpura <[email protected]>
  • Loading branch information
DarshitChanpura committed Dec 3, 2024
1 parent 37cacf0 commit 4107407
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
public static ShareWith fromXContent(XContentParser parser) throws IOException {
List<SharedWithScope> sharedWithScopes = new ArrayList<>();

// Ensure we're at the start of the object
if (parser.currentToken() != XContentParser.Token.START_OBJECT) {
parser.nextToken();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public class NoOpResourceAccessControlPlugin implements ResourceAccessControlPlu
@Override
public List<String> listAccessibleResourcesInPlugin(String systemIndexName) {
// returns an empty list since security plugin is disabled
// TODO: check whether this should return all entries in the given index
return List.of();
}

Expand Down

0 comments on commit 4107407

Please sign in to comment.