Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Nested Function Documentation #4308

Conversation

forestmvey
Copy link

Description

Added documentation section in SQL for nested function added to V2 engine in PR-1490 and PR-1657. The added features covers the nested function used in SQL.

PDF

Nested Function - OpenSearch documentation.pdf

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@forestmvey forestmvey force-pushed the integ-sql-nested-function branch from 987da7d to 1c1daee Compare June 13, 2023 16:46
@Naarcha-AWS Naarcha-AWS self-assigned this Jul 3, 2023
@Naarcha-AWS Naarcha-AWS assigned vagimeli and unassigned Naarcha-AWS Nov 14, 2023
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress Needs SME Waiting on input from subject matter expert labels Nov 14, 2023
@Naarcha-AWS Naarcha-AWS added this to the Weeks 47/48 milestone Nov 14, 2023
@vagimeli
Copy link
Contributor

@penghuo Will you please provide a technical review of this PR by Dec 15? I'll provide the documentation review to address writing and formatting matters, so your focus is only the technical accuracy of the content. Please reach out if we need to discuss this request or the review process. Thank you, Melissa

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the documentation review feedback, which focuses on writing and formatting. Tech review in progress. Final read through needed by editorial before PR is merged. Thank you.

_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
_search-plugins/sql/sql/nested.md Show resolved Hide resolved
@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed Needs SME Waiting on input from subject matter expert 3 - Tech review PR: Tech review in progress labels Dec 20, 2023
@vagimeli
Copy link
Contributor

Confirm dev author is former OpenSearch dev. Moving forward with doc review and editorial review.

@vagimeli
Copy link
Contributor

@hdhalter Author is now in an AWS role and this branch isn't available. Copied this content to a new branch and doc reviewed the content. It was written by a former OpenSearch dev. I sent it out for tech review anyway. See PR #5944

@vagimeli vagimeli closed this Dec 21, 2023
@vagimeli vagimeli added Closed - Complete Issue: Work is done and associated PRs closed and removed 4 - Doc review PR: Doc review in progress labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed - Complete Issue: Work is done and associated PRs closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants