Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geneate proto workflow #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucy66hw
Copy link

Description

Create a manual workflow to convert OpenSearch specifications into Protobuf files for testing tool development.

Workflow Steps:

  • Use merger to combine all specifications into a single YAML file.
  • Clone the development fork repository for Protobuf generation.
  • Extract and preprocess the target specification paths for conversion.
  • Build the JAR file using the forked repository.
  • Generate Protobuf files locally based on the specifications.

Issues Resolved

[FEATURE] Spec Conversion to Protobufs #707

@dblock
Copy link
Member

dblock commented Jan 14, 2025

Let's talk about tooling a little, I think we may be complicating things. At a high level, I think 75% of this Python code can be removed in favor of much simpler GitHub actions. All it does is drive command line java tools. For the rest (preprocessors), the entire tooling in this repo is TypeScript. Do we really want to introduce tools that are Python? This will make development much more difficult. We already have a lot of well tested code that processes and transforms spec files, so I am a little worried that this will become a Frankenstein repo that is very difficult to work in.

@lucy66hw
Copy link
Author

Thanks for the comment. This is a temporary workflow for protobuf generation. In the next phase, we plan to integrate wf into GitHub actions to automate the process alongside CI and implement preprocessing with typeScript.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for the next iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants