Fixed Mocha Dependency #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhtruong
requested review from
VijayanB,
jayeshathila,
robsears,
vamshin,
dblock and
VachaShah
as code owners
VachaShah
reviewed
Nov 2, 2022
CHANGELOG.md
Outdated
| @@ -12,8 +12,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Removed | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Mocha Dependency issue in `opensearch-dsl` gem | |||
There was a problem hiding this comment.
Are we adding PR details to Changelogs?
There was a problem hiding this comment.
Yes. Thanks for catching that. Though I think we should link the GH Issue instead if it's available so we don't have to deal with the chicken-and-egg issue when updating CHANGELOG.md, or when the PR is recreated with a new number.
VachaShah
previously approved these changes
Nov 2, 2022
Signed-off-by: Theo Truong <[email protected]>
VachaShah
approved these changes
Nov 8, 2022
|
@VijayanB @jayeshathila @vamshin Would you mind reviewing this PR? |
dblock
reviewed
Nov 9, 2022
| @@ -12,8 +12,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| ### Removed | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Mocha Dependency issue in `opensearch-dsl` gem ([#108](https://github.com/opensearch-project/opensearch-ruby/pull/108)) | |||
There was a problem hiding this comment.
Can I nitpick? It should say “Locked mocha …” because it doesn’t say what the issue is otherwise.
dblock
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opensearch-DSL gem was using Mocha 1.x.x for its unit tests. Mocha has just released 2.0.0 which breaks some of the tests. This will lock mocha to 1.x.x for Opensearch-DSL
Signed-off-by: Theo Truong [email protected]